✅ Refine NALAC tests

[ystade]

Description

This PR adds proper tests (and fixes revealed bugs) for the Neutral Atom Logical Array Compiler (NALAC).

Checklist:

• The pull request only contains commits that are related to it.
• I have added appropriate tests and documentation.
• I have made sure that all CI jobs on GitHub pass.
• The pull request introduces no new warnings and follows the project's style guidelines.

[ystade]

When cda-tum/mqt-core#629 is merged, the reference to MQT-Core must be adopted before merging this PR.

[codecov]

Codecov Report

Attention: Patch coverage is 97.05882% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.4%. Comparing base (e90df35) to head (8810409).
Report is 89 commits behind head on main.

Files with missing lines	Patch %	Lines
src/na/NAMapper.cpp	95.8%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##            main    #470     +/-   ##
=======================================
- Coverage   90.4%   90.4%   -0.1%     
=======================================
  Files         86      86             
  Lines       9975    9982      +7     
  Branches    1696    1696             
=======================================
+ Hits        9020    9025      +5     
- Misses       955     957      +2     

Flag	Coverage Δ		*Carryforward flag
cpp	90.1% <97.0%> (-0.1%)	⬇️
python	95.9% <ø> (ø)		Carriedforward from e90df35

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines	Coverage Δ
include/hybridmap/NeutralAtomArchitecture.hpp	97.6% <100.0%> (ø)
src/hybridmap/HardwareQubits.cpp	96.9% <100.0%> (ø)
src/hybridmap/HybridNeutralAtomMapper.cpp	92.4% <100.0%> (ø)
src/hybridmap/NeutralAtomArchitecture.cpp	96.7% <100.0%> (ø)
src/na/NAMapper.cpp	89.4% <95.8%> (+<0.1%)	⬆️

... and 1 file with indirect coverage changes

[ystade]

What happened here, @lsschmid. The error in the Release run on Linux throws an error in the hybrid mapper. I only renamed Euclidian to Euclidean because CLion complained.

[ystade]

@lsschmid Sorry, I completely looked wrong; the error did not stem from your code at all. 😃

[ystade]

@burgholzer I am still looking for the error but having trouble to locate it. So far, I am only running the failing windows test to get faster feedback and have put tons of std::cout in the code to locate the error. Do you have any suggestions on how to continue here?

[burgholzer]

@burgholzer I am still looking for the error but having trouble to locate it. So far, I am only running the failing windows test to get faster feedback and have put tons of std::cout in the code to locate the error. Do you have any suggestions on how to continue here?

Just quickly commenting here from the phone. Your best guess would probably be a Windows VM in debug mode and a test run started with the debugger attached..

Just depending on standard output is tough with these kinds of errors as they can be swallowed and not really surface, which might pinpoint you to the wrong location.

[burgholzer]

Ok. A bit of googling revealed:

• MSVC SEH exception with code 0xc0000005 when using SUCCEED google/googletest#4556, which links to
• New unexpected build failures on 20240603.1.0 actions/runner-images#10004

So this is not our fault. No need to debug further at the moment.

[ystade]

@burgholzer Tests are still running but should be clean now.

[burgholzer]

LGTM 👍🏼
Let's ignore the Windows failures for now and get this merged.
Not ideal, since there will be no coverage information, but there isn't that much that we could do 🤷🏼