-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚸 Support for adding tests to NALAC #629
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #629 +/- ##
=====================================
Coverage 91.6% 91.6%
=====================================
Files 148 148
Lines 14738 14736 -2
Branches 2365 2366 +1
=====================================
+ Hits 13506 13510 +4
+ Misses 1232 1226 -6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
Just a couple of comments on covering changes by tests and one slightly bigger comment on whether we can maybe simplify some of the code.
(Started the review before your last commit, so could be that some comments are obsolete by now)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like the overall suggestion and direction. Just some further comments.
And something broke due the change in |
virtual methods should not have default arguments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now ✅
Description
This PR contains modifications that were necessary for the tests of the Neutral Atom Logical Array Compiler, see cda-tum/mqt-qmap#470.
Checklist: