Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️🩹 fix and improve MQT Core linking #446

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

burgholzer
Copy link
Member

Description

A follow-up to #444 that fixes a particular linking issue and furthermore improves the overall library link time dependencies by removing the template code from the StateGenerator and moving the code to the .cpp file.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer added usability Anything related to usability c++ Anything related to C++ code fix Anything related to bugfixes labels Aug 14, 2024
@burgholzer burgholzer self-assigned this Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.3%. Comparing base (c634603) to head (dc4841b).
Report is 80 commits behind head on main.

Files with missing lines Patch % Lines
src/checker/dd/simulation/StateGenerator.cpp 94.1% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #446     +/-   ##
=======================================
- Coverage   95.4%   95.3%   -0.2%     
=======================================
  Files         40      40             
  Lines       1839    1838      -1     
  Branches     224     224             
=======================================
- Hits        1755    1752      -3     
- Misses        84      86      +2     
Flag Coverage Δ
cpp 95.6% <94.1%> (-0.2%) ⬇️
python 94.0% <ø> (ø)
Files with missing lines Coverage Δ
include/checker/dd/simulation/StateGenerator.hpp 100.0% <ø> (+4.1%) ⬆️
src/checker/dd/simulation/StateGenerator.cpp 94.8% <94.1%> (-5.2%) ⬇️

... and 1 file with indirect coverage changes

@burgholzer burgholzer enabled auto-merge (squash) August 14, 2024 15:54
@burgholzer burgholzer merged commit 7ab419c into main Aug 14, 2024
34 checks passed
@burgholzer burgholzer deleted the small-library-structure-refactor branch August 14, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code fix Anything related to bugfixes usability Anything related to usability
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant