Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ update mqt-core and adapt to changes #444

Merged
merged 4 commits into from
Aug 14, 2024
Merged

Conversation

burgholzer
Copy link
Member

Description

This PR updates MQT Core and adapts the code base to the changes from cda-tum/mqt-core#668.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer added dependencies Pull requests that update a dependency file c++ Anything related to C++ code labels Aug 14, 2024
@burgholzer burgholzer self-assigned this Aug 14, 2024
Signed-off-by: burgholzer <burgholzer@me.com>
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.8%. Comparing base (119c781) to head (df98be9).
Report is 86 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #444     +/-   ##
=======================================
- Coverage   96.0%   95.8%   -0.2%     
=======================================
  Files         39      39             
  Lines       1830    1831      +1     
  Branches     223     224      +1     
=======================================
- Hits        1757    1755      -2     
- Misses        73      76      +3     
Flag Coverage Δ
cpp 95.8% <100.0%> (-0.3%) ⬇️
python 95.8% <ø> (ø)
Files with missing lines Coverage Δ
include/EquivalenceCheckingManager.hpp 100.0% <ø> (ø)
include/checker/EquivalenceChecker.hpp 100.0% <ø> (ø)
include/checker/dd/DDAlternatingChecker.hpp 100.0% <ø> (ø)
include/checker/dd/DDConstructionChecker.hpp 83.3% <ø> (ø)
include/checker/dd/DDEquivalenceChecker.hpp 100.0% <ø> (ø)
include/checker/dd/DDSimulationChecker.hpp 100.0% <ø> (ø)
include/checker/dd/TaskManager.hpp 98.5% <ø> (ø)
...dd/applicationscheme/GateCostApplicationScheme.hpp 91.8% <ø> (ø)
include/checker/zx/ZXChecker.hpp 100.0% <ø> (ø)
src/EquivalenceCheckingManager.cpp 92.5% <100.0%> (-0.7%) ⬇️
... and 3 more

Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer merged commit 1ae653b into main Aug 14, 2024
34 checks passed
@burgholzer burgholzer deleted the update-mqt-core branch August 14, 2024 12:01
burgholzer added a commit that referenced this pull request Aug 14, 2024
## Description

A follow-up to #444 that fixes a particular linking issue and
furthermore improves the overall library link time dependencies by
removing the template code from the `StateGenerator` and moving the code
to the `.cpp` file.

## Checklist:

<!---
This checklist serves as a reminder of a couple of things that ensure
your pull request will be merged swiftly.
-->

- [x] The pull request only contains commits that are related to it.
- [x] I have added appropriate tests and documentation.
- [x] I have made sure that all CI jobs on GitHub pass.
- [x] The pull request introduces no new warnings and follows the
project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code dependencies Pull requests that update a dependency file
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant