-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ update mqt-core and adapt to changes #444
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgholzer
added
dependencies
Pull requests that update a dependency file
c++
Anything related to C++ code
labels
Aug 14, 2024
Signed-off-by: burgholzer <burgholzer@me.com>
burgholzer
force-pushed
the
update-mqt-core
branch
from
August 14, 2024 11:33
b9f4abc
to
3557ce2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #444 +/- ##
=======================================
- Coverage 96.0% 95.8% -0.2%
=======================================
Files 39 39
Lines 1830 1831 +1
Branches 223 224 +1
=======================================
- Hits 1757 1755 -2
- Misses 73 76 +3
|
burgholzer
force-pushed
the
update-mqt-core
branch
from
August 14, 2024 11:47
3557ce2
to
f3c6fb5
Compare
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
burgholzer
force-pushed
the
update-mqt-core
branch
from
August 14, 2024 11:49
f3c6fb5
to
df98be9
Compare
4 tasks
burgholzer
added a commit
that referenced
this pull request
Aug 14, 2024
## Description A follow-up to #444 that fixes a particular linking issue and furthermore improves the overall library link time dependencies by removing the template code from the `StateGenerator` and moving the code to the `.cpp` file. ## Checklist: <!--- This checklist serves as a reminder of a couple of things that ensure your pull request will be merged swiftly. --> - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines. Signed-off-by: burgholzer <burgholzer@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates MQT Core and adapts the code base to the changes from cda-tum/mqt-core#668.
Checklist: