Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 update framework #367

Merged
merged 21 commits into from
Aug 22, 2024
Merged

👷 update framework #367

merged 21 commits into from
Aug 22, 2024

Conversation

nquetschlich
Copy link
Collaborator

This PR

  • updates the pre-commit config
  • updates the CI/CD workflows
  • adds python 3.13 support

@nquetschlich
Copy link
Collaborator Author

The currently thrown errors 'StatePreparation' object has no attribute '_gates_to_uncompute' are apparently a bug that will soon be fixed in qiskit, see Qiskit/qiskit#12969 for details.

@nquetschlich nquetschlich changed the title 👷 updated framework 👷 update framework Aug 20, 2024
@burgholzer
Copy link
Member

The currently thrown errors 'StatePreparation' object has no attribute '_gates_to_uncompute' are apparently a bug that will soon be fixed in qiskit, see Qiskit/qiskit#12969 for details.

Alright. Given that this is supposedly fixed in 1.2.1, the easiest fix would be to exclude the 1.2.0 release here, I.e.

"qiskit!=1.2.0", # skip faulty qiskit release

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.0%. Comparing base (d9a35dd) to head (051788d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #367     +/-   ##
=======================================
+ Coverage   92.0%   93.0%   +0.9%     
=======================================
  Files         48      48             
  Lines       2466    2426     -40     
=======================================
- Hits        2270    2257     -13     
+ Misses       196     169     -27     
Flag Coverage Δ
python 93.0% <100.0%> (+0.9%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nquetschlich nquetschlich marked this pull request as ready for review August 22, 2024 07:53
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this. Just did a very quick review and left some comments. Hopefully shouldn't take too long to incorporate. Similar feedback probably also applies to the predictor PR.

.github/workflows/cd.yml Outdated Show resolved Hide resolved
.github/workflows/cd.yml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
src/mqt/bench/benchmarks/random.py Show resolved Hide resolved
src/mqt/bench/devices/ibm.py Outdated Show resolved Hide resolved
nquetschlich and others added 3 commits August 22, 2024 11:03
Co-authored-by: Lukas Burgholzer <burgholzer@me.com>
Signed-off-by: Nils Quetschlich <nils.quetschlich@tum.de>
Co-authored-by: Lukas Burgholzer <burgholzer@me.com>
Signed-off-by: Nils Quetschlich <nils.quetschlich@tum.de>
Co-authored-by: Lukas Burgholzer <burgholzer@me.com>
Signed-off-by: Nils Quetschlich <nils.quetschlich@tum.de>
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional changes! LGTM now ✅

@nquetschlich nquetschlich merged commit 6fbab24 into main Aug 22, 2024
28 checks passed
@nquetschlich nquetschlich deleted the update_framework branch August 22, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants