Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port over improvements to lab tools #1374

Merged
merged 3 commits into from
Mar 5, 2022

Conversation

chaosvolt
Copy link
Member

@chaosvolt chaosvolt commented Mar 3, 2022

Summary

SUMMARY: Balance "Microcentrifuges can also separate, port over recipe for separation funnel"

Purpose of change

So a while back Critsybear remarked in his recent BN playthrough that it's really weird that you can't use the microcentrifuge to do separation work, when that's part of what it's for. Turns out after a quick search I found a PR that agreed with this sentiment, but it got canned under the apparent belief that you can't separate a suspension using another tool that's literally designed to do that kinda thing. Also evidently a tool that analyzes a blood sample as a plot point during a mission can't do analysis, lel.

However, my initial plan to port over that PR has to be shelved because it turns out terrain can't yet make use of crafting_pseudo_item. I'll need to save that for a follow-up PR, in which I either convert centrifuges to furniture, or figure out how to rig support for terrain providing crafting stuff.

Aside from realism, remaining changes make separator funnels less of a roadblock to mutagen production.

Describe the solution

  1. Gave microcentrifuge the separation quality.
  2. Ported over a recipe that makes separation funnels craftable. I decided to roll the needed plastic stuff into the recipe itself, instead of the source PR having a separate recipe for an otherwise-not-used-for-anything stopcock item. I would've had to hunt down whatever PR added said stopcock item anyway.

Describe alternatives you've considered

  1. Simplifying mutagen production to not use a ton of science tools that have literally no other use in BN or DDA.
  2. Adding more uses to said otherwise useless tools, this PR is already technically a step towards that.

Testing

  1. Checked affected files for syntax and lint errors.
  2. Load-tested in test build.

Additional context

Sources:

  1. Craftable sep funnels, by Broken27: Added recipe for separation funnel CleverRaven/Cataclysm-DDA#41689

Additional credit to Critsybear for his BN playthrough as Numerius, and for reminding me about this in DMs (after which I kinda forgot, whoops).

Not covered by the above: addition of separation quality to microcentrifuge.

To be done in a follow-up: Centrifuge update PR, by zachary-kaelan: CleverRaven/Cataclysm-DDA#34344

Source provided in in Zach's PR that covers a good bit of details on the use of funnels vs tubes: https://chem.libretexts.org/Bookshelves/Organic_Chemistry/Organic_Chemistry_Lab_Techniques_(Nichols)/04%3A_Extraction/4.06%3A_Step-by-Step_Procedures_For_Extractions In particular, see the "Microscale Extractions" section, which covers the use of centrifuge tubes (either on their own or after running through a centrifuge).

Pinging @zachary-kaelan as they may enjoy seeing their work make it into BN. Leaving the mention here so they aren't potentially left wondering about a phantom ping, their idea will be ported to BN soon hopefully.

@chaosvolt
Copy link
Member Author

Huh. Terrain doesn't have support for crafting_pseudo_item? I could've sworn it did?

@Coolthulhu Coolthulhu self-assigned this Mar 5, 2022
"category": "CC_OTHER",
"subcategory": "CSC_OTHER_TOOLS",
"skill_used": "fabrication",
"difficulty": 7,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires full set of tools, but only cheap ingredients.
4 fab would be good.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lel, more results of copying DDA's recipes. Will do.

@Coolthulhu Coolthulhu merged commit b78b1ec into cataclysmbnteam:upload Mar 5, 2022
@chaosvolt chaosvolt deleted the centrifugation branch March 5, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants