Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide recommendation for migration to R 4.0 #830

Merged
merged 7 commits into from
Aug 4, 2020
Merged

Conversation

zkamvar
Copy link
Contributor

@zkamvar zkamvar commented Jul 24, 2020

Derived from conversations in the June maintainer meeting.

cc @jcoliver @HaoZeke

@netlify
Copy link

netlify bot commented Jul 24, 2020

Deploy preview for stupefied-einstein-5bde90 ready!

Built with commit 34d3071

https://deploy-preview-830--stupefied-einstein-5bde90.netlify.app

@HaoZeke
Copy link
Member

HaoZeke commented Jul 24, 2020

Looks great to me. Thanks for setting this up!

I'm adding an example from the R Social Science lesson to make sure that there is a positive recommendation for lesson maintainers to draw from.
Copy link
Member

@naupaka naupaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo.

_posts/2020/08/2020-08-03-r-4-migration.md Outdated Show resolved Hide resolved
Copy link
Member

@HaoZeke HaoZeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent ^_^

Copy link
Contributor

@atheobold atheobold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made changes to the history of factors and suggestions for ways maintainers can more meaningfully introduce them in their lessons.

_posts/2020/08/2020-08-03-r-4-migration.md Outdated Show resolved Hide resolved
_posts/2020/08/2020-08-03-r-4-migration.md Outdated Show resolved Hide resolved
Co-authored-by: Allison Theobold <atheobol@calpoly.edu>
Co-authored-by: Allison Theobold <atheobol@calpoly.edu>
@zkamvar
Copy link
Contributor Author

zkamvar commented Aug 3, 2020

Thank you for your input @atheobold! This definitely improves the tone of the post and gives valuable information. Would you mind adding your name to the Author list? https://github.com/carpentries/carpentries.org/pull/830/files#diff-97b5acc7d7fc4a2fc596284eee1ad44dR3

This post will go live tomorrow at 1400 UTC.

zkamvar and others added 2 commits August 4, 2020 07:24
Co-authored-by: Allison Theobold <atheobol@calpoly.edu>
- updated blog post tags
- added the summary recommendation as a standalone quote for emphasis
- reworded two sections for clarity
- removed the dissonance quantifier ' small ' from a sentence
@kmomar kmomar merged commit ee28b63 into gh-pages Aug 4, 2020
@kmomar kmomar deleted the zkamvar-r-4 branch August 4, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants