Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miskey:// visibility flags updated #1257

Merged
merged 1 commit into from
Dec 16, 2024
Merged

miskey:// visibility flags updated #1257

merged 1 commit into from
Dec 16, 2024

Conversation

caronc
Copy link
Owner

@caronc caronc commented Dec 15, 2024

Description:

Related issue (if applicable): #1251

Misskey appears to have changed it's supported flags around. Using 2 sources, there are conflicts even with those.

Source 1: https://misskey-hub.net/en/docs/for-users/features/note/
image

Source 2: https://docs.rs/misskey-api/latest/misskey_api/model/note/enum.Visibility.html
image

Source 2 provides actual Enum values, so will adapt on this for this PR.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@1251-misskey-visibility

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  "misskey://credentials"

Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.36%. Comparing base (551fa0d) to head (514077a).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1257      +/-   ##
==========================================
- Coverage   99.36%   99.36%   -0.01%     
==========================================
  Files         159      159              
  Lines       20687    20686       -1     
  Branches     3715     3715              
==========================================
- Hits        20556    20555       -1     
  Misses        121      121              
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc linked an issue Dec 15, 2024 that may be closed by this pull request
Copy link

@Albirew Albirew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe Source 1 is meant for end-users (Misskey webclient) and Source 2 for API calls.

Tried locally, worked with "specified" visibility flag. Worked as intended for private.
Screenshot 2024-12-16 at 21-32-44

LGTM

@caronc caronc merged commit dcc3a60 into master Dec 16, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

misskey service ignoring visibility
2 participants