misskey service ignoring visibility

[Albirew]

📣 Notification Service(s) Impacted
Misskey

🐞 Describe the bug
since wiki page doesn't show how visibility parameter is used in syntax, i assumed misskey://{token}@{host}/{visibility}
...and visibility parameter got magnificently ignored

💡 Screenshots and Logs

2024/12/08 18:46:28,000 - SENDING - [{"title": "Notification - https://changedetection.io/CHANGELOG.txt", "body": "https://changedetection.io/CHANGELOG.txt had a change.\n---\n(changed) Example text: change detection is cool\n(changed) Example text: some more examples\n(into) Example text: change detection is fantastic\n(into) Example text: even more examples\n(into) Example text: a lot more examples\n---", "url": "misskeys://REDACTED@REDACTED/private?avatar_url=https://raw.githubusercontent.com/dgtlmoon/changedetection.io/master/changedetectionio/static/images/avatar-256x256.png", "body_format": "markdown"}]

PS: private notes shoud have a letter icon next to date

💻 Your System Details:

• OS: debian 12
• Python Version: whatever embedded in changedetection.io docker image (3.11?)

🔮 Additional context
fresh install using provided docker-compose file

[caronc]

Magnificantly ignored indeed; just wasn't requested at the time. The current implementation just posts basic messages, but can be expanded to support more options if needed. Not sure if this is a bug so much as it is more of an enhancment.

[Albirew]

oh, i filled it as a bug since the parameter exists in documentation, but an enhancement is fine, too =)

[caronc]

You're right! 🫥

[Albirew]

after some search, i found in

apprise/test/test_plugin_misskey.py

Line 81 in 4d21759

('misskeys://access_token@hostname?visibility=private', {

now i have my arg syntax, let's try it using misskeys://{token}@{host}?visibility={visibility}
result:

2024/12/09 22:21:59,000 - SENDING - null
b'{"error":{"message":"Invalid param.","code":"INVALID_PARAM","id":"3d81ceae-475f-4600-b2a8-2bc116157532","kind":"client","info":{"param":"#/properties/visibility/enum","reason":"must be equal to one of the allowed values"}}}'
2024-12-09 22:21:59,209 - DEBUG - Response Details:
2024-12-09 22:21:59,209 - WARNING - Failed to send Misskey notification: Bad Request - Unsupported Parameters., error=400.
2024-12-09 22:21:59,171 - DEBUG - Misskey Payload: {'i': 'REDACTED', 'text': 'Notification - https://changedetection.io/CHANGELOG.txt\r\nhttps://changedetection.io/CHANGELOG.txt had a change.\n---\n(changed) Example text: change detection is cool\n(changed) Example text: some more examples\n(into) Example text: change detection is fantastic\n(into) Example text: even more examples\n(into) Example text: a lot more examples\n---', 'visibility': 'private'}
2024-12-09 22:21:59,171 - DEBUG - Misskey GET URL: https://REDACTED/api/notes/create (cert_verify=True)
2024-12-09 22:21:59,171 - DEBUG - Loaded Misskey URL: misskeys://y...F@REDACTED/?visibility=private&format=text&overflow=upstream

it looks like visibility parameter has been taken into account, but notification sending still failed as it looks like visibility is... not supported?

[caronc]

I'll look into this when I can; thank you for sharing the update 🙏

[caronc]

According to here and here, private is no longer an enum type. If anything, the change to Apprise would be to remove support for it now.

EDIT: Perhaps it's been renamd to direct (other website says its specified; so documentation conflicts) I will start with specifiedsince those docs appear to be more recent. Will send PR for test/review.

[caronc]

Please see attached PR and help test if you can 🙏

[Albirew]

Thanks. Is it possible to also edit wiki page to :

• remove private references
• add a table to explain all visibility parameters
• adding visibility flag to example ("misskeys://misskey.sda1.net/abcdefghijklmn?visibility=home")

(people outside project cannot edit or PR wiki, apparently)

[caronc]

I updated the wiki, I'll add your example suggestion soon

[Albirew]

Perfect 👍

Ah, you wrote direct in wiki, but it should be specified
specified is working but direct doesn't:

2024-12-17 19:34:53,471 - ERROR - Could not load Misskey URL: misskeys://y...F@s...a?visibility=direct
You must specify at least one server URL or populated configuration file.
Try 'apprise --help' for more information.

[caronc]

Thanks, i updated this! Good catch.