Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminated non-essential warning log in mailto:// parsing #1216

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Eliminated non-essential warning log in mailto:// parsing #1216

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
260d30a
Eliminated non-essential warning log in mailto:// parsing
caronc Oct 4, 2024
33e1ff2
fixed pep8
caronc Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions apprise/plugins/email.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@
from ..conversion import convert_between
from ..utils import is_ipaddr, is_email, parse_emails, is_hostname, parse_bool
from ..locale import gettext_lazy as _
from ..logger import logger

try:
import pgpy
Expand Down Expand Up @@ -1440,14 +1439,9 @@ def parse_url(url):
from_addr = NotifyEmail.unquote(results['qsd']['from'])

if 'name' in results['qsd'] and len(results['qsd']['name']):
# Depricate use of both `from=` and `name=` in the same url as
# they will be synomomus of one another in the future.
from_addr = formataddr(
(NotifyEmail.unquote(results['qsd']['name']), from_addr),
charset='utf-8')
logger.warning(
'Email name= and from= are synonymous; '
'use one or the other.')

elif 'name' in results['qsd'] and len(results['qsd']['name']):
# Extract from name to associate with from address
Expand Down
Loading