Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminated non-essential warning log in mailto:// parsing #1216

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

caronc
Copy link
Owner

@caronc caronc commented Oct 4, 2024

Description:

Related issue (if applicable): #1207

Eliminated non-essential warning in the mailto:// parsing

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@1207-mailto-warnings?

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  "mailto://credentials/"

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.36%. Comparing base (130edde) to head (33e1ff2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1216      +/-   ##
==========================================
- Coverage   99.36%   99.36%   -0.01%     
==========================================
  Files         148      148              
  Lines       20682    20680       -2     
  Branches     4042     4042              
==========================================
- Hits        20551    20549       -2     
  Misses        121      121              
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc merged commit ec368e2 into master Oct 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant