chore(build): bring Netlify build back #2428
Conversation
asudoh
force-pushed
the
gather-deploy-files-react
branch
2 times, most recently
from
6408fe7 to
a1c49f1
Compare
GitHub workflow stuffs we are investigating may solve this problem space. This PR is a stop-gap approach until we make the idea in action - Which is, build deploy artifacts for each and collect them into a single directory so the index.html can refer to. This also enables Netlify build for our React variant. Refs carbon-design-system#2406.
asudoh
force-pushed
the
gather-deploy-files-react
branch
from
a1c49f1 to
e729b15
Compare
| @@ -21,7 +21,7 @@ | |||
| "format": "prettier --write '**/*.{js,md,scss,ts}' '!**/{build,es,lib,storybook,ts,umd,components}/**'", | |||
| "format:diff": "prettier --list-different '**/*.{js,md,scss,ts}' '!**/{build,es,lib,storybook,ts,umd,components}/**'", | |||
| "format:staged": "prettier --write", | |||
| "gather-deploy-files": "yarn workspaces run gather-deploy-files", | |||
| "gather-deploy-files": "yarn workspace carbon-components gather-deploy-files && yarn workspace carbon-components-react gather-deploy-files", | |||
There was a problem hiding this comment.
This can just be lerna run gather-deploy-files I believe right?
There was a problem hiding this comment.
Great suggestion - Was looking for something similar, thanks @vpicone!
|
@asudoh unfortunately we'll run into the 15min build timeout that Netlify enforces if we build/deploy all packages in a PR. Most likely we'll need a way to trigger builds based on changed package directories. |
|
@joshblack You are right - Given such 15min limit, this PR creates Netlify build for components/React only, as a stop-gap measure. (Update: And also limit dependent |
|
@asudoh I'm not sure if you checked Slack, but I went ahead and pointed the old carbon apps to this repo instead of doing one build for everything 👍 Can see in: #2650 what the CI checks will be. Will not require us to do anything custom and can just use the same steps from before, with a little tweaks with lerna. |
|
OK great thanks @joshblack for doing #2650! Will take a look |
|
Closing this with the fix in #2650! 👍 |
GitHub workflow stuffs we are investigating may solve this problem space. This PR is a stop-gap approach until we make the idea in action - Which is, build deploy artifacts for each and collect them into a single directory so the index.html can refer to.
This also enables Netlify build for our React variant.
Refs #2406.
Changelog
New
carbon-componentsNetlify build (some recent change may have made it required).Testing / Reviewing
Testing should make sure our Netlify build is back working.
NOTE: The build took 7 mins which I hope is safe enough for US time, too.