chore(build): run Netlify for components package #2406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for the-carbon-components ready! Built with commit 7546d3f https://deploy-preview-2406--the-carbon-components.netlify.com |
emyarod
approved these changes
May 7, 2019
alisonjoseph
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
|
Thanks @emyarod and @alisonjoseph for reviewing! |
asudoh
added a commit
to asudoh/carbon-components
that referenced
this pull request
May 9, 2019
GitHub workflow stuffs we are investigating may solve this problem space. This PR is a stop-gap approach until we make the idea in action - Which is, build deploy artifacts for each and collect them into a single directory so the index.html can refer to. This also enables Netlify build for our React variant. Refs carbon-design-system#2406.
asudoh
added a commit
to asudoh/carbon-components
that referenced
this pull request
May 9, 2019
GitHub workflow stuffs we are investigating may solve this problem space. This PR is a stop-gap approach until we make the idea in action - Which is, build deploy artifacts for each and collect them into a single directory so the index.html can refer to. This also enables Netlify build for our React variant. Refs carbon-design-system#2406.
asudoh
added a commit
to asudoh/carbon-components
that referenced
this pull request
May 9, 2019
GitHub workflow stuffs we are investigating may solve this problem space. This PR is a stop-gap approach until we make the idea in action - Which is, build deploy artifacts for each and collect them into a single directory so the index.html can refer to. This also enables Netlify build for our React variant. Refs carbon-design-system#2406.
asudoh
added a commit
to asudoh/carbon-components
that referenced
this pull request
May 9, 2019
GitHub workflow stuffs we are investigating may solve this problem space. This PR is a stop-gap approach until we make the idea in action - Which is, build deploy artifacts for each and collect them into a single directory so the index.html can refer to. This also enables Netlify build for our React variant. Refs carbon-design-system#2406.
asudoh
added a commit
to asudoh/carbon-components
that referenced
this pull request
May 9, 2019
GitHub workflow stuffs we are investigating may solve this problem space. This PR is a stop-gap approach until we make the idea in action - Which is, build deploy artifacts for each and collect them into a single directory so the index.html can refer to. This also enables Netlify build for our React variant. Refs carbon-design-system#2406.
asudoh
added a commit
that referenced
this pull request
May 9, 2019
GitHub workflow stuffs we are investigating may solve this problem space. This PR is a stop-gap approach until we make the idea in action - Which is, build deploy artifacts for each and collect them into a single directory so the index.html can refer to. This also enables Netlify build for our React variant. Refs #2406.
asudoh
added a commit
that referenced
this pull request
May 9, 2019
GitHub workflow stuffs we are investigating may solve this problem space. This PR is a stop-gap approach until we make the idea in action - Which is, build deploy artifacts for each and collect them into a single directory so the index.html can refer to. This also enables Netlify build for our React variant. Refs #2406.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some nice ideas wrt how to enable multiple Netlify previews per package. This PR is a stop-gap approach until we make the idea in action - Which is, build deploy artifacts for each and collect them into a single directory so the
index.htmlcan refer to.Changelog
New
package.jsonscript for above.Changed
Testing / Reviewing
Testing should make sure our demo is not broken, especially regular dev env.