Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(percy): snap 2 widths on white theme, config network-idle-timeout #18416

Merged
merged 4 commits into from
Jan 24, 2025

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Jan 23, 2025

Testing if Percy will catch this change in the white theme in the mobile screen under 360px

See comment below ⬇️

@guidari guidari requested a review from a team as a code owner January 23, 2025 20:41
@guidari guidari requested review from kennylam and emyarod and removed request for kennylam and emyarod January 23, 2025 20:41
Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 338725d
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6793f322c48a7f0008f5bf34
😎 Deploy Preview https://deploy-preview-18416--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 338725d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6793f3225b049b00072bb487
😎 Deploy Preview https://deploy-preview-18416--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 338725d
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6793f3224f1eca0008558beb
😎 Deploy Preview https://deploy-preview-18416--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.15%. Comparing base (eee39f8) to head (338725d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18416   +/-   ##
=======================================
  Coverage   84.15%   84.15%           
=======================================
  Files         408      408           
  Lines       14443    14443           
  Branches     4641     4691   +50     
=======================================
  Hits        12155    12155           
+ Misses       2124     2123    -1     
- Partials      164      165    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tay1orjones
Copy link
Member

@guidari I think I figured it out! The widths condition was using context.themes instead of context.theme 🤦‍♂️

I also configured the network-idle-timeout to 1000ms instead of the default of 500ms, this should hopefully help ensure the font assets finish/settle during the asset discovery phase on percy's servers so we don't see snaps changing from Plex not being available.

@tay1orjones tay1orjones changed the title test: testing if percy will catch that test(percy): snap 2 widths on white theme, config network-idle-timeout Jan 24, 2025
@tay1orjones tay1orjones self-assigned this Jan 24, 2025
@tay1orjones
Copy link
Member

239 new snaps @ mobile width and one snap updated with plex 👍

@tay1orjones tay1orjones added this pull request to the merge queue Jan 24, 2025
Merged via the queue into carbon-design-system:main with commit 8acd725 Jan 24, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants