Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tags): high contrast with long text #18238

Merged
merged 3 commits into from
Dec 11, 2024
Merged

fix(tags): high contrast with long text #18238

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60849ac
fix(tags): high contrast with long text
ariellalgilmore Dec 10, 2024
61bdacd
Merge branch 'main' into fix/tag-high-contrast-with-long-text
tay1orjones Dec 10, 2024
41b1912
fix(tags): revert stories
ariellalgilmore Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react/src/components/Tag/InteractiveTag.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ export const Dismissible = (args) => {
},
{
type: 'high-contrast',
text: 'Tag content 10',
text: 'Tag content 10 with a long text description',
},
{
type: 'outline',
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/components/Tag/Tag.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export const ReadOnly = (args) => {
{'Tag content'}
</Tag>
<Tag className="some-class" type="high-contrast" {...args}>
{'Tag content'}
{'Tag content with a long text description'}
</Tag>
<Tag className="some-class" type="outline" {...args}>
{'Tag content'}
Expand Down
4 changes: 4 additions & 0 deletions packages/styles/scss/components/tag/_tag.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,6 +482,10 @@
max-inline-size: convert.to-rem(176px);
}

.#{$prefix}--tag--high-contrast .#{$prefix}--definition-term {
color: $text-inverse;
}

.#{$prefix}--tag > .#{$prefix}--popover-container {
display: flex;
}
Expand Down
Loading