Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): update styles for button skeleton in modal footer #17906

Conversation

alisonjoseph
Copy link
Member

@alisonjoseph alisonjoseph commented Oct 29, 2024

Closes #17833

Changelog

  • exclude padding-block from from ButtonSkeleton styles within ModalFooter

Testing / Reviewing

Check test ComposedModal story.

  • Remove test story before merging

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit ef45468
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/672a244cfdfa3d0008c4ed69
😎 Deploy Preview https://deploy-preview-17906--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 3f1c362
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/672112a29be5b600086b85cf
😎 Deploy Preview https://deploy-preview-17906--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 3f1c362
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/672112a21406d000081dbabd
😎 Deploy Preview https://deploy-preview-17906--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit ef45468
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/672a244ccf07690008a9ab42
😎 Deploy Preview https://deploy-preview-17906--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit ef45468
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/672a244ce252770008fa4314
😎 Deploy Preview https://deploy-preview-17906--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.59%. Comparing base (6dc14bd) to head (ef45468).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17906      +/-   ##
==========================================
+ Coverage   81.16%   81.59%   +0.43%     
==========================================
  Files         406      406              
  Lines       14046    14047       +1     
  Branches     4403     4375      -28     
==========================================
+ Hits        11400    11462      +62     
+ Misses       2479     2421      -58     
+ Partials      167      164       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@kennylam kennylam added this pull request to the merge queue Nov 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 5, 2024
@alisonjoseph alisonjoseph added this pull request to the merge queue Nov 5, 2024
Merged via the queue into carbon-design-system:main with commit dee8852 Nov 5, 2024
40 checks passed
@alisonjoseph alisonjoseph deleted the skeleton-button-modal-bug-17833 branch November 5, 2024 21:13
@carbon-automation
Copy link
Contributor

Hey there! v11.70.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Using a Skeleton Button within a Composed Modal messes with the animation
3 participants