Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Using a Skeleton Button within a Composed Modal messes with the animation #17833

Closed
2 tasks done
ychavoya opened this issue Oct 22, 2024 · 0 comments · Fixed by #17906
Closed
2 tasks done

[Bug]: Using a Skeleton Button within a Composed Modal messes with the animation #17833

ychavoya opened this issue Oct 22, 2024 · 0 comments · Fixed by #17906

Comments

@ychavoya
Copy link
Contributor

Package

@carbon/react

Browser

Firefox, Chrome

Package version

v1.68

React version

v18.2

Description

When adding a Skeleton Button in a Composed Modal Footer, some padding styling for the button messes with the loading animation so it displays slightly below where it's supposed to be.

Image

As a workaround our team can use the loadingStatus prop of the ModalFooter, but it may not be the case for other teams, that is why I am creating this issue

Reproduction/example

https://stackblitz.com/edit/github-tzhljf?file=src%2FApp.jsx

Steps to reproduce

  • Add a <ButtonSkeleton /> component inside a <ModalFooter>

Suggested Severity

Severity 3 = User can complete task, and/or has a workaround within the user experience of a given component.

Application/PAL

No response

Code of Conduct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants