Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(combobox): rendering aria-label #17678

Merged
merged 2 commits into from
Oct 10, 2024
Merged

fix(combobox): rendering aria-label #17678

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e145c53
fix(combobox): rendering aria-label
ariellalgilmore Oct 8, 2024
e6dc643
test(combobox): update tests with aria-label and titleText
ariellalgilmore Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/react/src/components/ComboBox/ComboBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,7 +784,6 @@
const menuProps = useMemo(
() =>
getMenuProps({
'aria-label': deprecatedAriaLabel || ariaLabel,
ref: autoAlign ? refs.setFloating : null,
}),
[
Expand Down Expand Up @@ -827,6 +826,9 @@
aria-haspopup="listbox"
title={textInput?.current?.value}
{...getInputProps({
'aria-label': titleText
? undefined

Check warning on line 830 in packages/react/src/components/ComboBox/ComboBox.tsx

View check run for this annotation

Codecov / codecov/patch

packages/react/src/components/ComboBox/ComboBox.tsx#L830 

Added line #L830 was not covered by tests
: deprecatedAriaLabel || ariaLabel,
'aria-controls': isOpen ? undefined : menuProps.id,
placeholder,
ref: mergeRefs(textInput, ref),
Expand Down
Loading