-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(combobox): rendering aria-label #17678
fix(combobox): rendering aria-label #17678
Conversation
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17678 +/- ##
==========================================
+ Coverage 77.08% 77.37% +0.28%
==========================================
Files 409 409
Lines 14024 14079 +55
Branches 4355 4374 +19
==========================================
+ Hits 10810 10893 +83
+ Misses 3044 3017 -27
+ Partials 170 169 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! I think the test coverage should be pretty easy to bump up. My guess is the old placement was never covered by tests, and now this adds "new" lines that it expects to be covered.
@tay1orjones updated the tests! |
993fb9c
* fix(combobox): rendering aria-label * test(combobox): update tests with aria-label and titleText
Closes #16557
Combobox was ignoring the
aria-label
propChangelog
Changed
aria-label
was being applied to themenuProps
, but the menu was already being given anaria-label
from thelistboxMenuIcon
aria-label
toinputProps
and handle the scenario whentitleText
isn't providedTesting / Reviewing