Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(combobox): rendering aria-label #17678

Conversation

ariellalgilmore
Copy link
Member

Closes #16557

Combobox was ignoring the aria-label prop

Changelog

Changed

  • previously aria-label was being applied to the menuProps, but the menu was already being given an aria-label from the listboxMenuIcon
  • moved aria-label to inputProps and handle the scenario when titleText isn't provided

Testing / Reviewing

  • pull down the branch
  • open storybook
  • go to combobox
  • add an aria-label to the combobox
  • run the IBM accessibility checker

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit e6dc643
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67069c5d5630ad0008fb1bb6
😎 Deploy Preview https://deploy-preview-17678--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e6dc643
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67069c5d4c145e000860d811
😎 Deploy Preview https://deploy-preview-17678--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ariellalgilmore ariellalgilmore marked this pull request as ready for review October 8, 2024 14:10
@ariellalgilmore ariellalgilmore requested a review from a team as a code owner October 8, 2024 14:10
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.37%. Comparing base (b345fb9) to head (e6dc643).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17678      +/-   ##
==========================================
+ Coverage   77.08%   77.37%   +0.28%     
==========================================
  Files         409      409              
  Lines       14024    14079      +55     
  Branches     4355     4374      +19     
==========================================
+ Hits        10810    10893      +83     
+ Misses       3044     3017      -27     
+ Partials      170      169       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I think the test coverage should be pretty easy to bump up. My guess is the old placement was never covered by tests, and now this adds "new" lines that it expects to be covered.

@ariellalgilmore
Copy link
Member Author

@tay1orjones updated the tests!

@alisonjoseph alisonjoseph added this pull request to the merge queue Oct 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 10, 2024
@alisonjoseph alisonjoseph added this pull request to the merge queue Oct 10, 2024
Merged via the queue into carbon-design-system:main with commit 993fb9c Oct 10, 2024
35 of 36 checks passed
@ariellalgilmore ariellalgilmore deleted the fix/combo-box-aria-label branch October 10, 2024 15:35
annawen1 pushed a commit to annawen1/carbon that referenced this pull request Oct 11, 2024
* fix(combobox): rendering aria-label

* test(combobox): update tests with aria-label and titleText
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants