Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle bluebird promise cancellation #487

Merged
merged 2 commits into from
Apr 25, 2016
Merged

Handle bluebird promise cancellation #487

merged 2 commits into from
Apr 25, 2016

Conversation

jaroslav-muller
Copy link

No description provided.

@vqvu
Copy link
Collaborator

vqvu commented Apr 21, 2016

Can you add a note about handling bluebird cancels in the docs for wrapping a promise in a stream (here)? Also, finally can't be used as a property name in this way in ES3 (which we technically support but don't test for right now). You need to changes usages of it to promise['finally'].

@jaroslav-muller
Copy link
Author

Done.
I had to disable a eslint rule (for two lines only) as eslint doesn't like finally in the bracket notation.

@vqvu
Copy link
Collaborator

vqvu commented Apr 25, 2016

Great! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants