You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I understand promise cancellation is not standardized, however I use bluebird together with highland and cancellation. Stream created via _(promise) gets blocked when the promise is cancelled.
It's caused by the fact that cancelled promise calls neither success nor error handler, so highland doesn't notice that the promise is finished.
However, it still calls finally handler. The fix seems to be easy, just change this:
finally isn't standardized either, so we'd need to gate the new behavior behind a _.isFunction(promise.finally) check. Do you mind submitting a PR for this?
I understand promise cancellation is not standardized, however I use bluebird together with highland and cancellation. Stream created via _(promise) gets blocked when the promise is cancelled.
It's caused by the fact that cancelled promise calls neither success nor error handler, so highland doesn't notice that the promise is finished.
However, it still calls finally handler. The fix seems to be easy, just change this:
to this
The text was updated successfully, but these errors were encountered: