Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADVAPP-269]: Correct SLA response trigger dependency #493

Merged

Conversation

mxm1070
Copy link
Contributor

@mxm1070 mxm1070 commented Feb 1, 2024

Ticket(s) or GitHub Issue

Technical Description

Added new No Response status to handle initial SLA compliance state confusion.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)

Screenshots (if appropriate)

Any deployment steps required?

A deployment step could be a command that needs to be executed or an ENV key that needs to be added, for example.

  • No

Before contributing and submitting this PR, make sure you have:

  • Read the contributing guidelines.
  • Title the PR with the ticket/issue number and a short description of the changes made. Or if no ticket/issue exists, title the PR with a short description of the changes made
  • Linked a relevant ticket or issue or describe the issue/feature which this PR resolves/implements.
  • Resolved all conflicts, if any.
  • Rebased your branch PR on top of the latest upstream main branch.

@mxm1070 mxm1070 requested a review from Orrison February 1, 2024 21:24
@mxm1070 mxm1070 self-assigned this Feb 1, 2024
Copy link
Collaborator

@Orrison Orrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per discussion in slack. Let's not do the new compliance status and just return the number at this time.

Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mxm1070 mxm1070 requested a review from Orrison February 1, 2024 21:39
@Orrison Orrison merged commit e7dc587 into main Feb 1, 2024
7 checks passed
@Orrison Orrison deleted the fix/advapp-269-correct-sla-response-trigger-dependency branch February 1, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants