Merge pull request #493 from canyongbs/fix/advapp-269-correct-sla-res…

…ponse-trigger-dependency [ADVAPP-269]: Correct SLA response trigger dependency
canyongbs · Feb 1, 2024 · e7dc587 · e7dc587
2 parents 89a29c9 + 49125be
commit e7dc587
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/app-modules/service-management/src/Models/ServiceRequest.php b/app-modules/service-management/src/Models/ServiceRequest.php
@@ -275,10 +275,10 @@ public function latestOutboundServiceRequestUpdate(): HasOne
             });
     }
 
-    public function getLatestResponseSeconds(): ?int
+    public function getLatestResponseSeconds(): int
     {
         if (! $this->latestInboundServiceRequestUpdate) {
-            return null;
+            return $this->created_at->diffInSeconds(now());
         }
 
         if (
@@ -331,7 +331,7 @@ public function getResponseSlaComplianceStatus(): ?SlaComplianceStatus
 
         $latestResponseSeconds = $this->getLatestResponseSeconds();
 
-        return ($latestResponseSeconds <= $slaResponseSeconds)
+        return $latestResponseSeconds <= $slaResponseSeconds
             ? SlaComplianceStatus::Compliant
             : SlaComplianceStatus::NonCompliant;
     }