Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADVAPP-978]: Enhance the user list experience by introducing filters for users who have no assigned permissions #1134

Merged
merged 8 commits into from
Nov 27, 2024
Merged

[ADVAPP-978]: Enhance the user list experience by introducing filters for users who have no assigned permissions #1134

merged 8 commits into from
Nov 27, 2024

Conversation

amit-canyon
Copy link
Contributor

Ticket(s) or GitHub Issue

Technical Description

Enhance the user list experience by introducing filters for users who have no assigned permissions

Any deployment steps required?

No

Are any Feature Flags and/or Data Migrations that can eventually be removed Added?

No

Before contributing and submitting this PR, make sure you have Read, agree, and are compliant with the contributing guidelines.

@amit-canyon amit-canyon added the Change Type | New Feature New feature or request label Nov 23, 2024
@amit-canyon amit-canyon requested a review from a team as a code owner November 23, 2024 09:25
@amit-canyon amit-canyon requested a review from Orrison November 27, 2024 05:32
@Orrison Orrison added this pull request to the merge queue Nov 27, 2024
@Orrison Orrison removed this pull request from the merge queue due to a manual request Nov 27, 2024
danharrin
danharrin reviewed Nov 27, 2024
View reviewed changes
Copy link
Contributor

@danharrin danharrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase/merge main into this branch and make the same suggested changes on #1129 please? Let me know if you have any issues and we can meet

app/Filament/Resources/UserResource/Pages/ListUsers.php Outdated Show resolved Hide resolved
app/Filament/Resources/UserResource/Pages/ListUsers.php Show resolved Hide resolved
app/Filament/Resources/UserResource/Pages/ListUsers.php Outdated Show resolved Hide resolved
app/Filament/Resources/UserResource/Pages/ListUsers.php Outdated Show resolved Hide resolved
app/Filament/Resources/UserResource/Pages/ListUsers.php Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Orrison Orrison enabled auto-merge November 27, 2024 19:37
@Orrison Orrison added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit 758d10c Nov 27, 2024
6 checks passed
@Orrison Orrison deleted the feature/ADVAPP-978 branch November 27, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danharrin danharrin danharrin approved these changes

@Orrison Orrison Orrison approved these changes

Assignees
No one assigned
Labels
Change Type | New Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amit-canyon @Orrison @danharrin