Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADVAPP-979]: Enhance the user list experience by introducing a filter for "no assigned team" #1129

Merged
merged 10 commits into from
Nov 27, 2024

Conversation

amit-canyon
Copy link
Contributor

Ticket(s) or GitHub Issue

Technical Description

Enhance the user list experience by introducing a filter for "no assigned team"

Any deployment steps required?

No

Are any Feature Flags and/or Data Migrations that can eventually be removed Added?

No


Before contributing and submitting this PR, make sure you have Read, agree, and are compliant with the contributing guidelines.

@amit-canyon amit-canyon added the Change Type | New Feature New feature or request label Nov 22, 2024
@amit-canyon amit-canyon requested a review from a team as a code owner November 22, 2024 09:41
@amit-canyon amit-canyon marked this pull request as draft November 22, 2024 09:41
@amit-canyon amit-canyon marked this pull request as ready for review November 22, 2024 18:24
Copy link
Collaborator

@Orrison Orrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danharrin please review as well

@Orrison Orrison requested a review from danharrin November 25, 2024 14:58
@amit-canyon amit-canyon requested a review from Orrison November 25, 2024 16:54
Copy link
Contributor

@danharrin danharrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The options are not grouped yet, did you try that bit of the ticket?

@amit-canyon
Copy link
Contributor Author

The options are not grouped yet, did you try that bit of the ticket?

@danharrin Sorry, but i didn't getting you, please explain little bit more here. Thanks.

@amit-canyon amit-canyon requested a review from Orrison November 27, 2024 05:28
@Orrison Orrison added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit e9e40d5 Nov 27, 2024
6 checks passed
@Orrison Orrison deleted the features/ADVAPP-979 branch November 27, 2024 16:44
jayushi-canyon pushed a commit that referenced this pull request Nov 27, 2024
…r for "no assigned team" (#1129)

* Add unassign filter into users team filter

* add count in test

* Add test case for team filter

* remove unneccessory function

* chore: fix code style

* Add new test

* Teams filter add group options

* replace id to getKey

---------

Co-authored-by: amit-canyon <amit-canyon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Change Type | New Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants