Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set resource limits and requests for Tempo #24

Merged
merged 4 commits into from
Aug 30, 2024
Merged

Set resource limits and requests for Tempo #24

merged 4 commits into from
Aug 30, 2024

Conversation

michaeldmitry
Copy link
Contributor

Solution

Provide resources_requests and a container_name to patch it with those k8s resource requests to generic coordinator object.

Context

  • Rationale behind the requests values for cpu and memory is documented here.
  • tempo container will be patched as its the highest resource consuming container.
  • Status for patch operation is collected in cos-lib collect-unit-status.

Testing

Run scenario tests.

@michaeldmitry michaeldmitry requested a review from a team as a code owner August 26, 2024 10:26
@michaeldmitry michaeldmitry mentioned this pull request Aug 26, 2024
Merged
PietroPasotti
PietroPasotti approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@PietroPasotti PietroPasotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michaeldmitry michaeldmitry merged commit ba7b88b into main Aug 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PietroPasotti PietroPasotti PietroPasotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaeldmitry @PietroPasotti