-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set resource limits and requests for HA #62
Conversation
9c0c737
to
33dd417
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need a little bit more documentation/context to know what I'm reviewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more thoughts
a3400f0
to
24690e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some things I missed in my previous review, sorry about that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job!
Solution
A generic implementation for HA charms to provide
resources_requests
and acontainer_name
to patch it with those k8s resource requests.Context
limits
portion would be a charm's config option (e.g: cpu_limits, memory_limits)resources_limit_options
.requests
portion would be hardcoded in the charm code.resources_requests
and acontainer_name
to get the dictionary of cpu and memory requests. The charm can pass a callable that sets dynamic requests values if needed.KubernetesComputeResourcesPatch
"Push" statuses into "Pull" statuses observability-libs#107