Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow numbers in component names #4945

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Jul 30, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

  • Allows for digits in component names
  • Refactor to use same validation for snap and component names
  • Begin snap and component names errors with a lowercase character

Depends on canonical/craft-parts#790

Fixes LP#2069783
(CRAFT-3043)

@mr-cal mr-cal changed the title Work/craft 3043/component names with digits feat: allow numbers in component names Jul 30, 2024
@mr-cal mr-cal added the rebase label Jul 30, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.66%. Comparing base (011dd11) to head (5954426).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4945      +/-   ##
==========================================
+ Coverage   89.64%   89.66%   +0.01%     
==========================================
  Files         334      335       +1     
  Lines       22401    22458      +57     
==========================================
+ Hits        20082    20137      +55     
- Misses       2319     2321       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mr-cal
Copy link
Collaborator Author

mr-cal commented Jul 31, 2024

CI is failing because this reference is excluded here

@mr-cal mr-cal requested review from mattculler and cmatsuoka July 31, 2024 13:56
@mr-cal mr-cal force-pushed the work/CRAFT-3043/component-names-with-digits branch from 5954426 to 2d6d7ac Compare August 2, 2024 13:43
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal force-pushed the work/CRAFT-3043/component-names-with-digits branch from 2d6d7ac to 8d39284 Compare August 2, 2024 13:44
@mr-cal mr-cal requested a review from lengau August 2, 2024 15:08
@cmatsuoka
Copy link
Contributor

The implementation seems good, but we should test valid component names using names containing numbers.

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal removed the request for review from lengau August 6, 2024 13:38
@mr-cal mr-cal added squash and removed rebase labels Aug 6, 2024
@mr-cal mr-cal merged commit 8ab7fd0 into main Aug 6, 2024
9 of 10 checks passed
@mr-cal mr-cal deleted the work/CRAFT-3043/component-names-with-digits branch August 6, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants