-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow numbers in component names #4945
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4945 +/- ##
==========================================
+ Coverage 89.64% 89.66% +0.01%
==========================================
Files 334 335 +1
Lines 22401 22458 +57
==========================================
+ Hits 20082 20137 +55
- Misses 2319 2321 +2 ☔ View full report in Codecov by Sentry. |
CI is failing because this reference is excluded here |
5954426
to
2d6d7ac
Compare
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
2d6d7ac
to
8d39284
Compare
The implementation seems good, but we should test valid component names using names containing numbers. |
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
tox run -m lint
?tox run -e test-py310
? (supported versions:py39
,py310
,py311
,py312
)Depends on canonical/craft-parts#790
Fixes LP#2069783
(CRAFT-3043)