Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow numbers in partition names and namespaces #790

Merged
merged 3 commits into from
Aug 1, 2024
Merged

feat: allow numbers in partition names and namespaces #790

merged 3 commits into from
Aug 1, 2024

Conversation

mr-cal
Copy link
Contributor

@mr-cal mr-cal commented Jul 30, 2024

  • Have you signed the CLA?

Allow hyphens in partitions, partition namespaces, and namespaced partitions.

Unblocks LP#2069783
(CRAFT-3043)

@mr-cal mr-cal force-pushed the work/CRAFT-3043/partition-names branch 2 times, most recently from 26d9df7 to cc66eeb Compare July 30, 2024 19:35
@mr-cal
feat: allow numbers in partition names and namespaces
a93be33 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal force-pushed the work/CRAFT-3043/partition-names branch from cc66eeb to a93be33 Compare July 30, 2024 19:36
@mr-cal mr-cal requested review from cmatsuoka and mattculler July 30, 2024 20:49
@mr-cal mr-cal mentioned this pull request Jul 30, 2024
Merged
4 tasks
mattculler
mattculler approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@mattculler mattculler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This will be a good one for me to look back at when I add support for hyphens in the partition names, though that change will also have to check for environment variable collisions.

@mr-cal mr-cal requested a review from lengau July 31, 2024 20:34
@mr-cal
Copy link
Contributor Author

mr-cal commented Jul 31, 2024

Nice. This will be a good one for me to look back at when I add support for hyphens in the partition names, though that change will also have to check for environment variable collisions.

I made an issue and referenced it in the code so we don't foget about it: #789, https://github.com/canonical/craft-parts/pull/790/files#diff-419889a2643383d0b091576acef698b735583eccd40f18ea2eb10298c7fd524bR133

@mattculler
Copy link
Contributor

Nice. This will be a good one for me to look back at when I add support for hyphens in the partition names, though that change will also have to check for environment variable collisions.

I made an issue and referenced it in the code so we don't foget about it: #789, https://github.com/canonical/craft-parts/pull/790/files#diff-419889a2643383d0b091576acef698b735583eccd40f18ea2eb10298c7fd524bR133

You are the man!

lengau
lengau approved these changes Jul 31, 2024
View reviewed changes
craft_parts/lifecycle_manager.py Outdated Show resolved Hide resolved
craft_parts/utils/partition_utils.py Outdated Show resolved Hide resolved
craft_parts/utils/partition_utils.py Outdated Show resolved Hide resolved
@mr-cal
chore: feedback from PR
b9a0d3d 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal merged commit b212893 into main Aug 1, 2024
10 checks passed
@mr-cal mr-cal deleted the work/CRAFT-3043/partition-names branch August 1, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattculler mattculler mattculler approved these changes

@lengau lengau lengau approved these changes

@cmatsuoka cmatsuoka Awaiting requested review from cmatsuoka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mr-cal @mattculler @lengau