feat: use craft-application project variables

[cmatsuoka]

Define version and grade as craft-application project variables that can
be updated using craftctl.

• Have you followed the guidelines for contributing?
• Have you signed the CLA?
• Have you successfully run tox run -m lint?
• Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

---

[cmatsuoka]

Save the unit tests, save the world.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.09%. Comparing base (6ff3e0b) to head (623bb03).
Report is 16 commits behind head on feature/craft-application.

Additional details and impacted files

@@                      Coverage Diff                      @@
##           feature/craft-application    #4601      +/-   ##
=============================================================
+ Coverage                      88.83%   89.09%   +0.26%     
=============================================================
  Files                            327      332       +5     
  Lines                          22033    22081      +48     
=============================================================
+ Hits                           19573    19674     +101     
+ Misses                          2460     2407      -53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tigarmo]

As far as I can tell, the following tests are now OK regarding the adopt-info part (some are still failing for other reasons):

craftctl:test_snapcraftctl_compat (needs snapcraftctl)
craftctl:test_craftctl_get_set (I think theres a `snap install --edge core24` we can remove)
linters/library (still needs the gnome extension)
set-version-twice OK

[mr-cal]

LGTM, please re-request a review from me when the craft-app PR lands

[cmatsuoka]

Rebased on feature/craft-application.

[tigarmo]

not sure how up-to-date/ready for review this is but the latest spread tests are all broken

2024-02-23T17:25:02.4667064Z 2024-02-23 17:25:02 Error restoring google:ubuntu-22.04-64:tests/spread/providers/lxd-build-info (feb231723-613888) : 
2024-02-23T17:25:02.4668796Z -----
2024-02-23T17:25:02.4669897Z + cd ../snaps/make-hello
2024-02-23T17:25:02.4670870Z + unset SNAPCRAFT_BUILD_ENVIRONMENT
2024-02-23T17:25:02.4671892Z + snapcraft clean --use-lxd
2024-02-23T17:25:02.4672740Z Traceback (most recent call last):
2024-02-23T17:25:02.4673684Z   File "/snap/snapcraft/x1/bin/snapcraft", line 5, in <module>
2024-02-23T17:25:02.4674813Z     from snapcraft.application import main
2024-02-23T17:25:02.4676427Z   File "/snap/snapcraft/x1/lib/python3.10/site-packages/snapcraft/application.py", line 108, in <module>
2024-02-23T17:25:02.4677780Z     APP_METADATA = AppMetadata(
2024-02-23T17:25:02.4679143Z TypeError: AppMetadata.__init__() got an unexpected keyword argument 'project_variables'
2024-02-23T17:25:02.4680280Z -----

2024-02-23 17:25:10 Successful tasks: 0

oh is this now depending on the craft-app merge?

[cmatsuoka]

oh is this now depending on the craft-app merge?

The craft-app PR providing this functionality has already landed so I'm not sure what's happening here.

[tigarmo]

oh is this now depending on the craft-app merge?

The craft-app PR providing this functionality has already landed so I'm not sure what's happening here.

probably just have to update and re-rerun the tests

[cmatsuoka]

It seems to be good now.

[mr-cal]

Spread test failures look as-expected. Thanks!