fix(tests): core24 classic linter test expectations #4600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/craft-application #4600 +/- ##
=============================================================
+ Coverage 88.83% 88.88% +0.05%
=============================================================
Files 327 330 +3
Lines 22033 22066 +33
=============================================================
+ Hits 19573 19614 +41
+ Misses 2460 2452 -8 ☔ View full report in Codecov by Sentry. |
root@evolved-marten:~# sed -n -e 's/VERSION=\(.*\)/\1/p' /etc/os-release "24.04 (Noble Numbat)" root@evolved-marten:~# apt download libc6 Get:1 http://archive.ubuntu.com/ubuntu noble/main amd64 libc6 amd64 2.38-3ubuntu1 [3248 kB] Fetched 3248 kB in 4s (850 kB/s) root@evolved-marten:~# dpkg-deb -x libc6_2.38-3ubuntu1_amd64.deb x root@evolved-marten:~# find x | grep usr/lib/x86_64-linux-gnu/audit/sotruss-lib.so root@evolved-marten:~# echo $? 1 root@divine-piranha:~# sed -n -e 's/VERSION=\(.*\)/\1/p' /etc/os-release "22.04.4 LTS (Jammy Jellyfish)" root@divine-piranha:~# apt download libc6 Get:1 http://archive.ubuntu.com/ubuntu jammy-updates/main amd64 libc6 amd64 2.35-0ubuntu3.6 [3236 kB] Fetched 3236 kB in 3s (1146 kB/s) root@divine-piranha:~# dpkg-deb -x libc6_2.35-0ubuntu3.6_amd64.deb x root@divine-piranha:~# find x | grep usr/lib/x86_64-linux-gnu/audit/sotruss-lib.so x/usr/lib/x86_64-linux-gnu/audit/sotruss-lib.so Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
tigarmo
approved these changes
Feb 21, 2024
sergiusens
changed the title
|
seems we now need #4601 for the unit tests to pass |
lengau
approved these changes
Feb 22, 2024
|
I think we have a problem now with using the same Project class for core22 and core24 projects. This is a core22 spread failure: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox run -m lint?tox run -e test-py310? (supported versions:py39,py310,py311,py312)