Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop services on removal only if they exist #32

Merged
merged 1 commit into from
Mar 30, 2024
Merged

fix: stop services on removal only if they exist #32

merged 1 commit into from
Mar 30, 2024

Conversation

dariofaccin
Copy link
Contributor

Description

This PR aims to fix #29, by checking that services exist before stopping them.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@dariofaccin dariofaccin requested a review from a team as a code owner March 29, 2024 09:40
@dariofaccin dariofaccin changed the title fix: stop services on removal only they exist fix: stop services on removal only if they exist Mar 29, 2024
@dariofaccin dariofaccin force-pushed the TELCO-1098-fix-remove-hook-failure branch from 5868fb9 to 5e9b0f4 Compare March 30, 2024 16:44
@dariofaccin
fix: stop services on removal only they exist
06cd5ae 
Signed-off-by: Dario Faccin <dario.faccin@canonical.com>
@dariofaccin dariofaccin force-pushed the TELCO-1098-fix-remove-hook-failure branch from 5e9b0f4 to 06cd5ae Compare March 30, 2024 16:51
@dariofaccin dariofaccin merged commit aa9995f into main Mar 30, 2024
14 checks passed
@dariofaccin dariofaccin deleted the TELCO-1098-fix-remove-hook-failure branch March 30, 2024 16:57
@dariofaccin dariofaccin mentioned this pull request May 28, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gatici gatici gatici approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Charm removal fails if services have never started
2 participants
@dariofaccin @gatici