Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use pytest for unit tests #84

Merged
merged 5 commits into from
May 29, 2024

Conversation

dariofaccin
Copy link
Contributor

Description

This PR aims to remove unittest framework in favor of pytest, as described here.
Main changes:

  • Use fixtures to configure patches

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@dariofaccin dariofaccin requested a review from a team as a code owner May 27, 2024 14:36
tests/unit/test_charm.py Show resolved Hide resolved
tests/unit/test_upf_network.py Outdated Show resolved Hide resolved
tests/unit/test_upf_network.py Show resolved Hide resolved
tests/unit/test_upf_network.py Show resolved Hide resolved
tests/unit/test_charm.py Show resolved Hide resolved
Copy link
Contributor

@Gmerold Gmerold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor stuff.

tests/unit/test_charm.py Outdated Show resolved Hide resolved
tests/unit/test_charm.py Outdated Show resolved Hide resolved
tests/unit/test_charm.py Outdated Show resolved Hide resolved
tests/unit/test_charm.py Show resolved Hide resolved
@dariofaccin dariofaccin merged commit df0518e into main May 29, 2024
21 checks passed
@dariofaccin dariofaccin deleted the TELCO-1232-port-pytest-unit-tests branch May 29, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants