Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: bump ops to latest possible version #242

Merged
merged 2 commits into from
Jun 21, 2024
Merged

build: bump ops to latest possible version #242

merged 2 commits into from
Jun 21, 2024

Conversation

DnPlas
Copy link
Contributor

@DnPlas DnPlas commented Jun 18, 2024

@DnPlas DnPlas requested a review from a team as a code owner June 18, 2024 21:03
@orfeas-k
Copy link
Contributor

I see tests are failing due to mysql-k8s requirement of specific juju version https://github.com/canonical/mlflow-operator/actions/runs/9572177418/job/26390939593?pr=242#step:5:843. This is though because we use 8.0/edge while we should be using stable as we had agreed recently. Should we update its dependecy first?

@DnPlas
Copy link
Contributor Author

DnPlas commented Jun 19, 2024

I see tests are failing due to mysql-k8s requirement of specific juju version https://github.com/canonical/mlflow-operator/actions/runs/9572177418/job/26390939593?pr=242#step:5:843. This is though because we use 8.0/edge while we should be using stable as we had agreed recently. Should we update its dependecy first?

I have left a comment #241 (comment). Let's discuss over there.

@DnPlas
Copy link
Contributor Author

DnPlas commented Jun 20, 2024

Re-running CI because of

minio/0 [idle] error: unknown container reason "ImagePullBackOff": Back-off pulling image "registry.jujucharms.com/charm/81j63o4a2ldarn1umc22iyjz1q9l9g0sx5b8j/oci-image@sha256:1755999849a392bdf00b778705f4cf5c1c971a1ef55a17e9075e56f8d58bdc2f"
  mysql-k8s/0 [idle] error: unknown container reason "ImagePullBackOff": Back-off pulling image "registry.jujucharms.com/charm/62ptdfbrjpw3n9tcnswjpart30jauc6wc5wbi/mysql-image@sha256:8079d0631c91ca53d1d06b76afff4586811c1142e6c013fd6dc6d6d0a881c4a5"

orfeas-k
orfeas-k approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding mysql, I replied to the other PR pointing in track.

@DnPlas DnPlas merged commit a3c1d82 into main Jun 21, 2024
8 checks passed
@DnPlas DnPlas deleted the KF-5567-bump-ops-latest branch June 21, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orfeas-k orfeas-k orfeas-k approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DnPlas @orfeas-k