Ensure resize configuration events are not superseded. (Fixes #449) #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmww
approved these changes
Jul 7, 2018
bors bot
added a commit
that referenced
this pull request
Jul 7, 2018
450: Ensure resize configuration events are not superseded. (Fixes #449) r=wmww a=AlanGriffiths Note there are couple of racy wlcs tests this breaks: XdgToplevelV6Configuration.maximized_and_unmaximized XdgToplevelV6Configuration.fullscreened_and_restored These are fixed in: canonical/wlcs#58 Co-authored-by: Alan Griffiths <alan@octopull.co.uk> Co-authored-by: William Wold <william.wold@canonical.com>
Build failed |
|
On Saturday, 7 July 2018 02:02:12 BST, William Wold ***@***.***> wrote:
wmww approved this pull request.
Appears to work. I've never been crazy about this whole system,
but this doesn't seem to make it any worse. We'll get a chance
to discuss and improve when I implement XDG shell stable.
bors r+
This can't land in its current form without the test changes you
(correctly) rejected earlier.
This is partly correct. But, as discussed on irc, we're still sending some
spurious configure() events. That needs fixing. (Without losing any of the
necessary ones.)
My first job on Monday.
…--
Alan Griffiths. +44 (0)798 9938 758
Octopull Limited. http://www.octopull.co.uk/
|
|
Oh, seen your comments on the wlcs PR. Sync'd with both master branches. |
|
bors r=wmww |
bors bot
added a commit
that referenced
this pull request
Jul 9, 2018
450: Ensure resize configuration events are not superseded. (Fixes #449) r=wmww a=AlanGriffiths Note there are couple of racy wlcs tests this breaks: XdgToplevelV6Configuration.maximized_and_unmaximized XdgToplevelV6Configuration.fullscreened_and_restored These are fixed in: canonical/wlcs#58 Co-authored-by: Alan Griffiths <alan@octopull.co.uk>
Build failed |
|
bors r=wmww |
bors bot
added a commit
that referenced
this pull request
Jul 9, 2018
450: Ensure resize configuration events are not superseded. (Fixes #449) r=wmww a=AlanGriffiths Note there are couple of racy wlcs tests this breaks: XdgToplevelV6Configuration.maximized_and_unmaximized XdgToplevelV6Configuration.fullscreened_and_restored These are fixed in: canonical/wlcs#58 Co-authored-by: Alan Griffiths <alan@octopull.co.uk>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note there are couple of racy wlcs tests this breaks:
XdgToplevelV6Configuration.maximized_and_unmaximized
XdgToplevelV6Configuration.fullscreened_and_restored
These are fixed in: canonical/wlcs#58