Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt demo apps are not fullscreened by miral-kiosk #449

Closed
AlanGriffiths opened this issue Jul 6, 2018 · 2 comments
Closed

Qt demo apps are not fullscreened by miral-kiosk #449

AlanGriffiths opened this issue Jul 6, 2018 · 2 comments
Assignees
Labels

Comments

@AlanGriffiths
Copy link
Collaborator

(Running on 18.04, 16.04 has additional issues)

$ sudo apt install mir-demos mir-graphics-drivers-desktop qtdeclarative5-examples
$ miral-app -kiosk -launcher /usr/lib/x86_64-linux-gnu/qt5/examples/quick/demos/photoviewer/photoviewer

Expect: photoviewer appears fullscreen
Actual: photoviewer appears at top left of display

@AlanGriffiths AlanGriffiths self-assigned this Jul 6, 2018
@AlanGriffiths
Copy link
Collaborator Author

This happens with both xdg-shell-v6 and wl-shell (i.e. MIR_DISABLE_XDG_SHELL_V6_UNSTABLE=on).

In both cases I can see the configure(..., $screen-size) notification being received by the client. But there's no correctly sized buffer being allocated.

@AlanGriffiths
Copy link
Collaborator Author

In contrast, using miral-shell:

$ miral-app -launcher /usr/lib/x86_64-linux-gnu/qt5/examples/quick/demos/photoviewer/photoviewer

And then forcing maximized (Alt-F11) from the shell does work as expected.

OTOH, the "tiling" window manager also fails to fullscreen the app:

$ miral-app -launcher /usr/lib/x86_64-linux-gnu/qt5/examples/quick/demos/photoviewer/photoviewer --window-manager tiling

bors bot added a commit that referenced this issue Jul 7, 2018
450: Ensure resize configuration events are not superseded. (Fixes #449) r=wmww a=AlanGriffiths

Note there are couple of racy wlcs tests this breaks:

XdgToplevelV6Configuration.maximized_and_unmaximized
XdgToplevelV6Configuration.fullscreened_and_restored

These are fixed in: canonical/wlcs#58

Co-authored-by: Alan Griffiths <alan@octopull.co.uk>
Co-authored-by: William Wold <william.wold@canonical.com>
bors bot added a commit that referenced this issue Jul 9, 2018
450: Ensure resize configuration events are not superseded. (Fixes #449) r=wmww a=AlanGriffiths

Note there are couple of racy wlcs tests this breaks:

XdgToplevelV6Configuration.maximized_and_unmaximized
XdgToplevelV6Configuration.fullscreened_and_restored

These are fixed in: canonical/wlcs#58

Co-authored-by: Alan Griffiths <alan@octopull.co.uk>
bors bot added a commit that referenced this issue Jul 9, 2018
450: Ensure resize configuration events are not superseded. (Fixes #449) r=wmww a=AlanGriffiths

Note there are couple of racy wlcs tests this breaks:

XdgToplevelV6Configuration.maximized_and_unmaximized
XdgToplevelV6Configuration.fullscreened_and_restored

These are fixed in: canonical/wlcs#58

Co-authored-by: Alan Griffiths <alan@octopull.co.uk>
@bors bors bot closed this as completed in 2243fd9 Jul 9, 2018
bors bot added a commit that referenced this issue Jul 13, 2018
462: Mir release 0.32.1 r=AlanGriffiths a=Saviq

### Enhancements:
- [libmiral] Launcher for internal Wayland clients. (#410)
- [miral-shell] Reinstate the "spinner" when starting miral-shell
  (re-implementing it in Wayland)
### Bugs fixed:
- [mesa-kms] Select EGLConfig matching our GBM format. (#435)
- [Wayland] Don't send output events that are not supported in the agreed
  protocol version. (#389)
- [Wayland] Ensure resize configuration events are not superseded. (#449)

Co-authored-by: Alan Griffiths <alan@octopull.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant