Do not kill X11 apps whose pop-ups don't support WM_DELETE_WINDOW #3203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3203 +/- ##
========================================
Coverage 77.81% 77.81%
========================================
Files 1062 1072 +10
Lines 74646 75093 +447
========================================
+ Hits 58087 58436 +349
- Misses 16559 16657 +98 ☔ View full report in Codecov by Sentry. |
AlanGriffiths
pushed a commit
that referenced
this pull request
Feb 2, 2024
Do not kill X11 apps whose pop-ups don't support WM_DELETE_WINDOW
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that Mir will hide the window anyway. It simply can't request the client delete it too.
Fixes: #3177