Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent live migration of instances with custom volumes #12733

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Prevent live migration of instances with custom volumes #12733

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
897ad29
lxd/instance_post: Update comments in instancePostClusteringMigrate f…
MusicDin Jan 17, 2024
908e12b
lxd/instance_post: Rename container to instance in instancePost function
MusicDin Jan 17, 2024
167f231
lxd/instance_post: Prevent live migration of instances with custom vo…
MusicDin Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions lxd/instance_post.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ func instancePost(d *Daemon, r *http.Request) response.Response {
return response.BadRequest(fmt.Errorf("Invalid instance name"))
}

// Flag indicating whether the node running the container is offline.
// Flag indicating whether the node running the instance is offline.
sourceNodeOffline := false

var targetProject *api.Project
Expand Down Expand Up @@ -168,7 +168,7 @@ func instancePost(d *Daemon, r *http.Request) response.Response {
// Cases 1. and 2. are the ones for which the conditional will be true
// and we'll either forward the request or load the instance.
if target == "" || !sourceNodeOffline {
// Handle requests targeted to a container on a different node.
// Handle requests targeted to an instance on a different node.
resp, err := forwardedResponseIfInstanceIsRemote(s, r, projectName, name, instanceType)
if err != nil {
return response.SmartError(err)
Expand Down Expand Up @@ -618,7 +618,7 @@ func instancePostMigration(s *state.State, inst instance.Instance, newName strin
return nil
}

// Move a non-ceph container to another cluster node.
// Move a non-ceph instance to another cluster node. Source and target members must be online.
func instancePostClusteringMigrate(s *state.State, r *http.Request, srcPool storagePools.Pool, srcInst instance.Instance, newInstName string, srcMember db.NodeInfo, newMember db.NodeInfo, stateful bool, allowInconsistent bool) (func(op *operations.Operation) error, error) {
srcMemberOffline := srcMember.IsOffline(s.GlobalConfig.OfflineThreshold())

Expand All @@ -629,7 +629,7 @@ func instancePostClusteringMigrate(s *state.State, r *http.Request, srcPool stor
}

// Save the original value of the "volatile.apply_template" config key,
// since we'll want to preserve it in the copied container.
// since we'll want to preserve it in the copied instance.
origVolatileApplyTemplate := srcInst.LocalConfig()["volatile.apply_template"]

// Check we can convert the instance to the volume types needed.
Expand Down Expand Up @@ -956,7 +956,16 @@ func migrateInstance(s *state.State, r *http.Request, inst instance.Instance, ta
return err
}

// Check if we are migrating a ceph-based instance.
// In case of live migration, only root disk can be migrated.
if req.Live && inst.IsRunning() {
for _, rawConfig := range inst.ExpandedDevices() {
if rawConfig["type"] == "disk" && !shared.IsRootDiskDevice(rawConfig) {
return fmt.Errorf("Cannot live migrate instance with attached custom volume")
}
}
}

// Retrieve storage pool of the source instance.
srcPool, err := storagePools.LoadByInstance(s, inst)
if err != nil {
return fmt.Errorf("Failed loading instance storage pool: %w", err)
Expand Down
Loading