Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent live migration of instances with custom volumes #12733

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

MusicDin
Copy link
Member

Error out if instance with attached custom volumes is being live migrated.

lxd/instance_post.go Outdated Show resolved Hide resolved
lxd/instance_post.go Outdated Show resolved Hide resolved
Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you split your commit into logical changes, there are 3 comment changes and 1 logic change, so expect 4 commits in total. This aids with backporting. ta

@MusicDin MusicDin force-pushed the fix/live-migration-custom-vols branch from 0f577b5 to 737c7ce Compare January 17, 2024 11:12
…unction

Signed-off-by: Din Music <din.music@canonical.com>
Signed-off-by: Din Music <din.music@canonical.com>
…lumes

Signed-off-by: Din Music <din.music@canonical.com>
@MusicDin MusicDin force-pushed the fix/live-migration-custom-vols branch from 737c7ce to 167f231 Compare January 17, 2024 11:15
@tomponline
Copy link
Member

Thanks @MusicDin LGTM

@tomponline tomponline merged commit 3634303 into canonical:main Jan 18, 2024
26 checks passed
@MusicDin MusicDin deleted the fix/live-migration-custom-vols branch January 18, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants