docs: correct the lifecycle step for organize
#996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lengau
approved these changes
Jan 29, 2025
|
Linting issue can be ignored as it's unrelated |
mr-cal
approved these changes
Jan 29, 2025
tigarmo
added a commit
that referenced
this pull request
Feb 3, 2025
…ks in Rockcraft. (#993) * style: autoformat * style: fix spelling * build(deps): fix dependencies to make tests succeed * style: adjust pylint configuration to make lint pass * ci: install chisel v0.10.0 * fix: chisel tests on 20.04 * style: autoformat * style: fix spelling * build(deps): fix dependencies to make tests succeed * style: adjust pylint configuration to make lint pass * ci: install chisel v0.10.0 * fix: chisel tests on 20.04 * fix: pyright * fix(ci): 20.04 packages * tests: create integration tests for talking to snapd * build(deps): replace requests-unixsocket with requests-unixsocket2 Fixes #852 * fix: bump python version * chore: bump version to 1.19.8 * tests: create integration tests for talking to snapd * build(deps): replace requests-unixsocket with requests-unixsocket2 * fix: bump python version * Bump version: 1.25.2 → 1.25.3 * style: fix linting errors * feat: add an API for registering source types (#927) This provides a pair of functions (sources.register, sources.unregister) for registering and unregistering source types. This differs slightly from plugin registration in current sources cannot be removed. * build: migrate to pyproject.toml (#902) Removes dependency on bumpversion in favor of git tags for versioning. Co-authored-by: Sergio Schvezov <sergio.schvezov@canonical.com> * build(deps): update dependency myst-parser to v4 (#871) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat: use "craft.git" for git where possible (#925) If "craft.git" is available on the PATH, use it. Otherwise, fallback to "git". Fixes #900 * doc: create new how-to on creating a plugin (#928) * feat: add uv plugin (#930) * fix: remove captured message on error (#937) Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> * docs: move changelog, add PR task (#942) * docs: move changelog to reference Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com> * ci: add PR task for changelog updates Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com> --------- Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com> * feat(plugins/poetry): add poetry and pip extra args (#940) This allows more customisation of the poetry and pip commands for advanced users. * docs(changelog): add 2.2.0 changes (#941) Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com> * doc: update docs with extra ref anchors (#945) * tests: deduplicate tests for python-based plugins (#947) * docs: clarify poetry-with field (#946) Co-authored-by: Alex Lowe <alex.lowe@canonical.com> * chore: fix some small pyproject errors, include uv.lock (#955) The pyproject file referenced some deprecated Ruff linter rules and incorrectly formatted the git describe command parameter, which had to be an array. This commit fixes both * fix: make uv plugin re-entrant on code changes (#956) * fix: correct git versioning error (#957) * build(deps): update dependency mypy to ~=1.14.1 (#958) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(docs): include poetry links as a target (#960) This allows applications that have their own custom poetry reference to include all the default links by adding the following to the bottom of their poetry plugin reference: .. include:: /common/craft-parts/reference/plugins/poetry_plugin.rst :start-after: .. _craft_parts_poetry_links: Signed-off-by: Alex Lowe <alex.lowe@canonical.com> * style: fix linting issues for ruff 0.9 (#969) * build(deps): update bugfixes (#952) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * ci: replace Renovate config with starflow (#968) Co-authored-by: Callahan <callahan.kovacs@canonical.com> * docs: update docstring for maven plugin (#971) Co-authored-by: Callahan <callahan.kovacs@canonical.com> Co-authored-by: Alex Lowe <alex.lowe@canonical.com> * feat(executor): allow capturing error message from scriptlets (#966) * change craftctl channel to socket Change to craftctl communication channel from named pipes to unix sockets to make it easier to consolidate the ctl server and error stream capture. * allow using process selector with custom handlers Process execution runs a selector to obtain data from i/o streams to obtain the isolated error output. Allow this selection loop run on a caller-specified selector with handlers registered to also process interactions with craftctl. * change scriptlet environment script name Step execution environment is step-specific, and the existing environment.sh script is for the build step only. Rename the file containing the scriptlet environment to avoid confusion with the existing file (which may potentially have a different payload). * force select selector Using DefaultSelector fails in jammy with Python 3.10. It seems that this specific version picks a different selector, or there's some problem with SelectSelector that prevents it from working as expected. --------- Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> * docs: update changelog (#984) Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> * fix: use source-subdir in go-use plugin It's possible, and somewhat common, for a go module to be defined inside a repo's subdir; in this case we can define source-subdir, but the go-use plugin needs to use this - otherwise the repo root gets used. Fixes #978 * docs: fix changelog, add go-use bugfix * feat(PartSpec): add source-channel attribute (#981) Signed-off-by: Dariusz Duda <dariusz.duda@canonical.com> * docs(changelog): finalize changelog for 2.4.0 (#988) Signed-off-by: Dariusz Duda <dariusz.duda@canonical.com> * fix: don't modify 'prefix' for relocatable pkg-config files (#977) A relocatable `.pc` file has a `prefix` key beginning with `${pcfiledir}`. The `prefix` key is not modified if the `.pc` file is relocatable. * fix(tests): don't fail if you have additional JREs (#986) Fixes #985 * docs(changelog): finalize changelog for 2.4.1 (#990) Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com> * feat: craftctl chroot command * docs: update and complete the step execution environment (#949) * docs: update and complete the step execution environment This adds a large number of missing environment variables from the step execution environment and updates the information about CRAFT_TARGET_ARCH and CRAFT_ARCH_TRIPLET being deprecated. Co-authored-by: Callahan <callahan.kovacs@canonical.com> Co-authored-by: JJ Coldiron <jj.coldiron@canonical.com> * fix(craft_parts/executor/step_handler.py): adjust subprocess command to stream output * fix:adjustments for linter * fix(tests/integration/lifecycle/test_craftctl.py): update expected error description * feat: add Jlink plugin (#951) Co-authored-by: Tiago Nobrega <tiago.nobrega@canonical.com> Co-authored-by: Michael DuBelko <michael.dubelko@gmail.com> Co-authored-by: Callahan Kovacs <callahan.kovacs@canonical.com> Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com> * docs: correct the lifecycle step for `organize` (#996) Co-authored-by: Callahan <callahan.kovacs@canonical.com> * fix(craft_parts/utils/process.py): migrate subprocess.run to internal process.run --------- Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com> Signed-off-by: Alex Lowe <alex.lowe@canonical.com> Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> Signed-off-by: Dariusz Duda <dariusz.duda@canonical.com> Co-authored-by: Alex Lowe <alex.lowe@canonical.com> Co-authored-by: Sergio Schvezov <sergio.schvezov@canonical.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Tiago Nobrega <tiago.nobrega@canonical.com> Co-authored-by: Imani Pelton <imani.pelton@canonical.com> Co-authored-by: Callahan <callahan.kovacs@canonical.com> Co-authored-by: Carl Csaposs <carl.csaposs@canonical.com> Co-authored-by: Yanks Yoon <37652070+yanksyoon@users.noreply.github.com> Co-authored-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> Co-authored-by: Dariusz Duda <dariusz.duda@canonical.com> Co-authored-by: Sergio Costas <sergio.costas@canonical.com> Co-authored-by: JJ Coldiron <jj.coldiron@canonical.com> Co-authored-by: Vladimir Petko <vladimir.petko@canonical.com> Co-authored-by: Michael DuBelko <michael.dubelko@gmail.com> Co-authored-by: Michael DuBelko <michael.dubelko@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/reference/changelog.rst)?Error was discovered in canonical/open-documentation-academy#163 (comment)