Changes for RK042 - Support for Pro Rocks in Rockcraft - 30/01/25 #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides a pair of functions (sources.register, sources.unregister) for registering and unregistering source types. This differs slightly from plugin registration in current sources cannot be removed.
Removes dependency on bumpversion in favor of git tags for versioning. Co-authored-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
If "craft.git" is available on the PATH, use it. Otherwise, fallback to "git". Fixes canonical#900
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Co-authored-by: Callahan <callahan.kovacs@canonical.com>
Co-authored-by: Callahan <callahan.kovacs@canonical.com> Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
…cal#966) * change craftctl channel to socket Change to craftctl communication channel from named pipes to unix sockets to make it easier to consolidate the ctl server and error stream capture. * allow using process selector with custom handlers Process execution runs a selector to obtain data from i/o streams to obtain the isolated error output. Allow this selection loop run on a caller-specified selector with handlers registered to also process interactions with craftctl. * change scriptlet environment script name Step execution environment is step-specific, and the existing environment.sh script is for the build step only. Rename the file containing the scriptlet environment to avoid confusion with the existing file (which may potentially have a different payload). * force select selector Using DefaultSelector fails in jammy with Python 3.10. It seems that this specific version picks a different selector, or there's some problem with SelectSelector that prevents it from working as expected. --------- Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
It's possible, and somewhat common, for a go module to be defined inside a repo's subdir; in this case we can define source-subdir, but the go-use plugin needs to use this - otherwise the repo root gets used. Fixes canonical#978
Signed-off-by: Dariusz Duda <dariusz.duda@canonical.com>
Signed-off-by: Dariusz Duda <dariusz.duda@canonical.com>
…l#977) A relocatable `.pc` file has a `prefix` key beginning with `${pcfiledir}`. The `prefix` key is not modified if the `.pc` file is relocatable.
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
* docs: update and complete the step execution environment This adds a large number of missing environment variables from the step execution environment and updates the information about CRAFT_TARGET_ARCH and CRAFT_ARCH_TRIPLET being deprecated. Co-authored-by: Callahan <callahan.kovacs@canonical.com> Co-authored-by: JJ Coldiron <jj.coldiron@canonical.com>
Co-authored-by: Tiago Nobrega <tiago.nobrega@canonical.com> Co-authored-by: Michael DuBelko <michael.dubelko@gmail.com> Co-authored-by: Callahan Kovacs <callahan.kovacs@canonical.com> Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Co-authored-by: Callahan <callahan.kovacs@canonical.com>
…feature/pro-sources
clay-lake
changed the title
|
Hey, @canonical/starcraft-reviewers @tigarmo Could I get this merged in? |
tigarmo
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/reference/changelog.rst)?Updates to complete feature set fot RK042 - Support for Pro Rocks in Rockcraft.