many: merge starbase/main #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-test # Conflicts: # tox.ini
Most static checks don't need the code to be installed at all, but type checking can require the code and its dependencies.
tools: Make typing use an editable install
tests: Ensure coverage gets per-environment filenames
Done the same way as in rockcraft Co-authored-by: Tiago Nobrega <tiago.nobrega@canonical.com>
docs: Basic sphinx docs
Rather than statically declaring the project to be "starcraft" all over the place, prefer excluding directories.
chore(tools): Make pyproject.toml exclude rather than statically include
chore(deps): update dependency tox to v4.4.2
chore(deps): update release-drafter/release-drafter action to v5.22.0
chore(deps): update dependency tox-ignore-env-name-mismatch to v0.2.0.post2
chore(deps): update dependency pytest to v7.2.1
Ensure that ruff only gets updated by renovate or explicitly in PRs. This will prevent random CI breakages until ruff is stable.
New ignore: Too many arguments on test functions * chore(lint): Ruff autofixes for new pylint
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Furo currently blocks us from updating to sphinx 7 pradyunsg/furo#653
Co-authored-by: Callahan <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahankovacs@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Otherwise it can pickup yml files from .git/remotes/...
tigarmo
commented
May 22, 2023
Codecov Report
@@ Coverage Diff @@
## main #74 +/- ##
=======================================
Coverage 88.09% 88.09%
=======================================
Files 13 13
Lines 630 630
Branches 125 125
=======================================
Hits 555 555
Misses 61 61
Partials 14 14 |
|
Leaving this as a Draft so we don't squash-merge by accident (needs to be a regular merge) |
lengau
approved these changes
May 22, 2023
|
Thanks for doing the heavy lifting for this! It looks great! |
|
It was actually surprisingly easy! About 15 minutes or so resolving the conflicts, and that's a price we'll only have to pay once (that's the hope anyway) |
|
Oh good, in that case you can do this for snapcraft ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit list is huge because this is bringing in the entirety of starbase/main; I think the important commits to look at are the last merge, done by me (most conflicts were solved by using the starbase version), and the handful of commits after that fixing linting issues.