Release 24.4.1 #5966
Merged
Release 24.4.1 #5966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous way was preventing passing multiple (or no) args.
get_meta_doc() is no longer used, but there may be custom modules that still try to reference it. Don't break them.
holmanb
approved these changes
Jan 14, 2025
|
I think we still want the 503 fix here, as well as this one. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
If the server is busy, no need to fail. Add type hints to adjacent code paths and necessary refactors. Fixes canonicalGH-5577 --------- Co-authored-by: Brett Holman <brett.holman@canonical.com>
There are use cases where we may want to recover or not treat a failure of this function as an error. This change lets the caller decide what to do. Logging was added to callsites that didn't already have it. Fixes canonicalGH-5971
holmanb
approved these changes
Jan 14, 2025
ChangeLog
Outdated
| @@ -1,3 +1,10 @@ | |||
| 24.4.1 | |||
| - fix: Don't log errro in wait_for_url (#5972) | |||
…anonical#5976) The function "_should_wait_via_user_data()" wasn't properly handling user data that has a header that starts with #cloud-config, but isn't cloud-config, like #cloud-config-archive Fixes canonicalGH-5975
Bump the version in cloudinit/version.py to 24.4.1 and update ChangeLog.
|
@holmanb , added one more cherry-pick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.