Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure when get_meta_doc() is called #5953

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

TheRealFalcon
Copy link
Member

Proposed Commit Message

See individual commits

Additional Context

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

The previous way was preventing passing multiple (or no) args.
get_meta_doc() is no longer used, but there may be custom modules that
still try to reference it. Don't break them.
Copy link
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@holmanb holmanb self-assigned this Jan 7, 2025
@TheRealFalcon TheRealFalcon merged commit f97e5fb into canonical:main Jan 8, 2025
22 checks passed
TheRealFalcon added a commit that referenced this pull request Jan 8, 2025
The previous way was preventing passing multiple (or no) args.
@TheRealFalcon TheRealFalcon deleted the fix-modules branch January 8, 2025 15:29
TheRealFalcon added a commit to TheRealFalcon/cloud-init that referenced this pull request Jan 13, 2025
The previous way was preventing passing multiple (or no) args.
TheRealFalcon added a commit to TheRealFalcon/cloud-init that referenced this pull request Jan 13, 2025
get_meta_doc() is no longer used, but there may be custom modules that
still try to reference it. Don't break them.
TheRealFalcon added a commit that referenced this pull request Jan 13, 2025
The previous way was preventing passing multiple (or no) args.
TheRealFalcon added a commit that referenced this pull request Jan 13, 2025
get_meta_doc() is no longer used, but there may be custom modules that
still try to reference it. Don't break them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants