Rework hooks to allow for easier integration with ROCK #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
MiaAltieri
reviewed
Feb 23, 2023
taurus-forever
approved these changes
Feb 24, 2023
| @@ -0,0 +1,31 @@ | |||
| #!/bin/bash | |||
|
|
|||
| set -eux | |||
There was a problem hiding this comment.
Do you need trace (x) by default?
There was a problem hiding this comment.
It's not required, but it is helpful if there was an error. If the install hook fails, the install fails, otherwise, the output is discarded.
Comment on lines
+29
to
+30
| chown -R 584788:root ${SNAP_DATA}/* | ||
| chown -R 584788:root ${SNAP_COMMON}/* |
There was a problem hiding this comment.
JFMI only, why we hardcode magic number 584788 instead of snap_daemon?
There was a problem hiding this comment.
It's for giving flexibility in the rock by not specifying the exact username. This allows us to use the mongo user in the script by setting the user id manually for both accounts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug Fix
What is the current behavior? (You can also link to an open issue here)
The configure hook handled all setup of the snap
What is the new behavior (if this is a feature change)?
Most of the configuration of the snap is done on an install hook and the configuration hook only handles the
snap setfeatures.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.
Other information:
N/A