Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert rock to use snap base #10

Merged
merged 9 commits into from
Feb 28, 2023
Merged

Conversation

jardon
Copy link
Contributor

@jardon jardon commented Feb 13, 2023

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Base change

  • What is the current behavior? (You can also link to an open issue here)
    All mongodb components are installed from percona-provided deb packages.

  • What is the new behavior (if this is a feature change)?
    The rock is now built using the charmed-mongodb snap instead of the official deb packages.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    Yes, you'll likely have to rewrite quite a few things to deal with confinement.

  • Other information:
    charmed-mongodb-snap repo

@jardon
Copy link
Contributor Author

jardon commented Feb 13, 2023

@delgod This PR wont work as-is. I believe for this to be usable I would need to expose an app to run mongod in the foreground. I could create an app called mongod-foreground that doesnt run as a daemon for use with the rock. Any thoughts?

Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tnx!

rockcraft.yaml Outdated Show resolved Hide resolved
@delgod
Copy link
Member

delgod commented Feb 14, 2023

@delgod This PR wont work as-is. I believe for this to be usable I would need to expose an app to run mongod in the foreground. I could create an app called mongod-foreground that doesnt run as a daemon for use with the rock. Any thoughts?

Let's research why it doesn't work, I don't understand the issue, I don't think mongod-foreground needed

@jardon jardon marked this pull request as ready for review February 15, 2023 20:54
@jardon
Copy link
Contributor Author

jardon commented Feb 16, 2023

The integration tests here are failing because of an incompatibility with cryptography and openssl.

The operator needs to be updated to fix this.

More details can be found here

@jardon
Copy link
Contributor Author

jardon commented Feb 16, 2023

Here is the associated mongodb-k8s-operator GH Issue.

@jardon jardon marked this pull request as draft February 22, 2023 16:44
@jardon
Copy link
Contributor Author

jardon commented Feb 22, 2023

This is depending on this PR to be merged.

@jardon
Copy link
Contributor Author

jardon commented Feb 22, 2023

These changes can be tested with 5.0/edge/rework-hooks, but are omitted in the PR.

@jardon jardon marked this pull request as ready for review February 24, 2023 22:47
@jardon jardon merged commit 090aded into canonical:5.0/stable Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants