Always validate the entrypoint, no matter its source. #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is somewhat entangled, because we're currently supporting different sources for entrypoint: configuration, command line option (deprecated), and the default when the developer didn't specify anything.
Besides the several explicit cases that I started to validate, I added one validation for the case of writing the absolute path in the config, which was missing, surely because when the parts lifecycle and plugin were introduced the entrypoint path started to be always relative, when before it was always absolute.
There's a remaining duplicated validation that will disappear when deprecations are enforced. This whole code will be quite more simple after that.
Fixes #761 .