Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The pack command does not validate the entrypoint unless it's specified #761

Closed
facundobatista opened this issue May 4, 2022 · 0 comments · Fixed by #767
Closed

The pack command does not validate the entrypoint unless it's specified #761

facundobatista opened this issue May 4, 2022 · 0 comments · Fixed by #767
Labels
Bug Something isn't working build Related to the build process critical Stuff that should be fixed ASAP triaged

Comments

@facundobatista
Copy link
Contributor

If pack is run without using the --entrypoint option, even if it defaults to src/charm.py, it's not running any validation on it (e.g. that is executable).
@facundobatista facundobatista added Bug Something isn't working critical Stuff that should be fixed ASAP build Related to the build process triaged labels May 4, 2022
@facundobatista facundobatista mentioned this issue May 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working build Related to the build process critical Stuff that should be fixed ASAP triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Always validate the entrypoint, no matter its source. canonical/charmcraft
1 participant
@facundobatista