Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new built in function to find duplicates #688

Merged
merged 5 commits into from
Jul 17, 2023
Merged

Add new built in function to find duplicates #688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e59be21
feat: add new built-in function to find duplicates
berkaycanbc Jul 17, 2023
a599ee1
feat: add new built-in function to find duplicates
berkaycanbc Jul 17, 2023
3f5800d
feat: add new built-in function to find duplicates
berkaycanbc Jul 17, 2023
b1898c6
docs: Add duplicate values() function
saig0 Jul 17, 2023
1eb3ae7
docs: Mark duplicate values() function as extension
saig0 Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions docs/docs/reference/builtin-functions/feel-built-in-functions-list.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,6 +464,25 @@ distinct values([1,2,3,2,1])
// [1,2,3]
```

## duplicate values(list)

<MarkerCamundaExtension></MarkerCamundaExtension>

Returns all duplicate values of the given list.

**Function signature**

```js
duplicate values(list: list): list
```

**Examples**

```js
duplicate values([1,2,3,2,1])
// [1,2]
```

## flatten(list)

Returns a list that includes all elements of the given list without nested lists.
Expand Down
6 changes: 6 additions & 0 deletions src/main/scala/org/camunda/feel/impl/builtin/ListBuiltinFunctions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ object ListBuiltinFunctions {
"index of" -> List(indexOfFunction),
"union" -> List(unionFunction),
"distinct values" -> List(distinctValuesFunction),
"duplicate values" -> List(duplicateValuesFunction),
"flatten" -> List(flattenFunction),
"sort" -> List(sortFunction),
"string join" -> List(joinFunction,
Expand Down Expand Up @@ -347,6 +348,11 @@ object ListBuiltinFunctions {
case List(ValList(list)) => ValList(list.distinct)
})

private def duplicateValuesFunction =
builtinFunction(params = List("list"), invoke = {
case List(ValList(list)) => ValList(list.distinct.filter(x => list.count(_ == x) > 1))
})

private def flattenFunction =
builtinFunction(params = List("list"), invoke = {
case List(ValList(list)) => ValList(flatten(list))
Expand Down
18 changes: 18 additions & 0 deletions src/test/scala/org/camunda/feel/impl/builtin/BuiltinListFunctionsTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,24 @@ class BuiltinListFunctionsTest
ValList(List(ValNumber(1), ValNumber(2), ValNumber(3))))
}

"A duplicate values() function" should "return duplicate values" in {

eval(" duplicate values([1,2,3,2,1]) ") should be(
ValList(List(ValNumber(1), ValNumber(2))))
}

it should "return null duplicate values" in {

eval(" duplicate values([1,2,1,null,null]) ") should be(
ValList(List(ValNumber(1), ValNull)))
}

it should "return duplicate values for named parameters" in {

eval(" duplicate values(list: [1,2,3,2,1]) ") should be(
ValList(List(ValNumber(1), ValNumber(2))))
}

"A flatten() function" should "flatten nested lists" in {

eval(" flatten([[1,2],[[3]], 4]) ") should be(
Expand Down