Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new built in function to find duplicates #688

Merged
merged 5 commits into from
Jul 17, 2023

Conversation

berkaycanbc
Copy link
Contributor

@berkaycanbc berkaycanbc commented Jul 17, 2023

Description

  • Add tests
  • Create a function to find duplicates.
  • Add test case for named list parameters.

Related issues

closes #642

* Add tests
* Create a function to find duplicates. It is not preserving the order of the list yet.
* Refactor the function to find duplicates. It is now preserving the order of the list.
* Add test case for named list parameters.
@berkaycanbc berkaycanbc requested a review from saig0 as a code owner July 17, 2023 12:45
saig0 added 2 commits July 17, 2023 15:15
Add documentation for the new duplicate values() function.
Mark the new duplicate values() function as a Camunda extension. It is not yet part of the OMG standard.
Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@berkaycanbc LGTM. 👍

It was a great session and an awesome first contribution. 🚀


I added one commit to the PR to mention the new function in the documentation. 📝

@saig0 saig0 added this pull request to the merge queue Jul 17, 2023
Merged via the queue into main with commit 9d94e83 Jul 17, 2023
@saig0 saig0 deleted the 642_add_new_built-in_function_to_find_duplicates branch July 17, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new built-in function to find duplicates
2 participants